Switch default reproduction-template to app #53453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
styfle
reviewed
Aug 1, 2023
Co-authored-by: Steven <steven@ceriously.com>
styfle
previously approved these changes
Aug 1, 2023
styfle
approved these changes
Aug 1, 2023
ijjk
added a commit
that referenced
this pull request
Aug 3, 2023
### What? Follow-up of #53453 ### Why? Forgot to update the link in a few places --------- Co-authored-by: Zack Tanner <zacktanner@gmail.com> Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating reproduction examples
Our current
pnpm create next-app -e reproduction-template, which is present in our Issues template, will create a Pages app. This PR updates the default (reproduction-template) to App Router, and adds areproduction-template-pagesexample.